pass reference to htsfile for better cram support #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although cram files are supported, I believe it only works if you have internet connection to download or a local cache of the reference genome. Without these you get decode errors like these
Since a reference is always required for variant calling, it is safe to always pass the reference to htslib when opening sam/bam/cram files. I tested this for a few different files with fairly default parameters and it worked fine, but I didn't test all possible modes.