Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass reference to htsfile for better cram support #278

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ASLeonard
Copy link
Contributor

Although cram files are supported, I believe it only works if you have internet connection to download or a local cache of the reference genome. Without these you get decode errors like these

[W::find_file_url] Failed to open reference "https://www.ebi.ac.uk/ena/cram/md5/<your chromosome hash>": Connection refused

Since a reference is always required for variant calling, it is safe to always pass the reference to htslib when opening sam/bam/cram files. I tested this for a few different files with fairly default parameters and it worked fine, but I didn't test all possible modes.

@zhengzhenxian
Copy link
Collaborator

@ASLeonard Billion thanks for the PR! Will test then.

@zhengzhenxian zhengzhenxian merged commit 9c07848 into HKU-BAL:main Mar 15, 2024
@aquaskyline
Copy link
Member

Merged into v1.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants