Fixes and Enhancements for PostgreSQL and JSON Document Storage #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanSte
reviewed
Feb 18, 2025
lightrag/kg/postgres_impl.py
Outdated
| element["id"]: DocProcessingStatus( | ||
| content=result[0]["content"], | ||
| content_summary=element["content_summary"], | ||
| content_length=element["content_length"], | ||
| status=element["status"], | ||
| created_at=element["created_at"], |
There was a problem hiding this comment.
Could you remove str()?
It is not needed here.
It comes from the other implementation.
Thanks 🙏🏻
|
How are we going to handle wiping out the database? |
|
Small reviews to apply after that I will merge. |
YanSte
reviewed
Feb 18, 2025
lightrag/kg/postgres_impl.py
Outdated
| element["id"]: DocProcessingStatus( | ||
| content=result[0]["content"], | ||
| content_summary=element["content_summary"], | ||
| content_length=element["content_length"], | ||
| status=element["status"], | ||
| created_at=element["created_at"], |
There was a problem hiding this comment.
Could you remove str()?
It is not needed here.
It comes from the other implementation.
Thanks 🙏🏻
| else: | ||
| exist_keys = [] | ||
| new_keys = set([s for s in keys if s not in exist_keys]) | ||
| print(f"keys: {keys}") |
There was a problem hiding this comment.
Could you please remove all the print. 🙏🏻
|
By the way thanks for the documentation for Postgres. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses several issues related to document storage in PostgreSQL and JSON handling. The following changes have been implemented:
Added Missing Drop Methods
Fixed Key Filtering for PostgreSQL
Fixed PostgreSQL Implementation for Status Gathering
Linting: