Refactor api server by split it to smaller files #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 'future' package - Removed 'networkx' package - Cleaned up commented sections - Maintained core dependencies - Simplified requirements structure
- Added FileResponse for webui root endpoint - Enabled directory check in StaticFiles mount - Improved webui static file handling - Ensured webui directory existence - Simplified webui access with root endpoint
- Added content fallback to content_summary - Handled missing fields gracefully - Made data copy to avoid modification - Added error logging for missing fields - Improved code readability and robustness
- Move parse_args and display_splash_screen functions from lightrag_server.py to utils_api.py - Move OllamaServerInfos class and instance from ollama_api.py to utils_api.py
- Fix refactoring error on pipeline_index_file - Delete unsed func: scan_directory - Add type hints of rag for better maintainability - Refine comments for better understanding
• Add rag param to function call • Fix argument mismatch error • Ensure proper pipeline execution
|
Hello, in this refactor. Could you extract Ollama please? Thanks 🙏🏻 |
|
without dependency on Ollama？ I can't get the points. API server just emulates an Ollama model for LightRAG, so chat frontend supporting Ollama API can use LightRAG directly. |
|
I mean it is not possible to use the default defined LLM, otherwise if it is not defined use ollama? |
Previously, the set_logger function would always set the log level to DEBUG, overriding any user-specified log level.
ParisNeo
approved these changes
Feb 21, 2025
| return default | ||
|
|
||
|
|
||
| def display_splash_screen(args: argparse.Namespace) -> None: |
There was a problem hiding this comment.
Hi.
Where did you move this part?
|
|
||
| # database packages | ||
| networkx | ||
| future |
| @@ -57,11 +57,17 @@ async def __aexit__(self, exc_type, exc, tb): | |||
| logging.getLogger("httpx").setLevel(logging.WARNING) | |||
|
|
|||
|
|
|||
| def set_logger(log_file: str): | |||
| logger.setLevel(logging.DEBUG) | |||
| def set_logger(log_file: str, level: int = logging.DEBUG): | |||
| for k, v in self._data.items() | ||
| if v["status"] == status.value | ||
| } | ||
| result = {} |
| @@ -0,0 +1,554 @@ | |||
| """ | |||
| Utility functions for the LightRAG API. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor api server by split it to smaller files.
Changes Made
Refactor lightrag_server.py by by split it to smaller files, an put it in
./routesImprove document status retrieval with content fallback for legacy storage file compatibility.
Change progress_lock for document scan from threading.Lock() to asyncio.Lock
Respect user-specified log level in set_logger
Checklist
Additional Notes
none