Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed get_knowledge_graph #886

Merged
merged 1 commit into from
Feb 19, 2025
Merged

removed get_knowledge_graph #886

merged 1 commit into from
Feb 19, 2025

Conversation

YanSte
Copy link
Contributor

@YanSte YanSte commented Feb 19, 2025

Description

  • removed get_knowledge_graph never implemented everywhere

Changes Made

  • removed get_knowledge_graph method

Checklist

  • Changes tested locally
  • Code reviewed

@@ -604,179 +603,6 @@ async def embed_nodes(
# -------------------------------------------------------------------------
# QUERY
# -------------------------------------------------------------------------
#

async def get_knowledge_graph(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for mango and neo4j so no needed

@YanSte YanSte merged commit cedb5f3 into HKUDS:main Feb 19, 2025
1 check passed
@YanSte YanSte deleted the clean-2 branch February 19, 2025 21:59
@ArnoChenFx
Copy link
Contributor

ArnoChenFx commented Feb 20, 2025

No! It's used by the WebUI. Every graph backend should implement the get_knowledge_graph interface.

#737 #792

export const queryGraphs = async (label: string): Promise<LightragGraphType> => {
const response = await axiosInstance.get(`/graphs?label=${label}`)
return response.data
}

const fetchGraph = async (label: string) => {
let rawData: any = null
try {
rawData = await queryGraphs(label)
} catch (e) {
useBackendState.getState().setErrorMessage(errorMessage(e), 'Query Graphs Error!')
return null
}

@YanSte

@YanSte
Copy link
Contributor Author

YanSte commented Feb 20, 2025

@ArnoChenFx Sorry I just got you message..

@YanSte
Copy link
Contributor Author

YanSte commented Feb 20, 2025

But @ArnoChenFx get_knowledge_graph is not implemented in Oracle and others, that will crash.

@YanSte
Copy link
Contributor Author

YanSte commented Feb 20, 2025

Again sorry for that @ArnoChenFx Will fallback this implementation.

@ArnoChenFx
Copy link
Contributor

@LarFii said he would implement the get_knowledge_graph for networkx. The get_knowledge_graph for neo4j existed before I wrote the webui, and the get_knowledge_graph for mongo was written by me using AI. Sorry, I don't have the ability to implement get_knowledge_graph for other backends.

@LarFii
Copy link
Collaborator

LarFii commented Feb 20, 2025

@LarFii said he would implement the get_knowledge_graph for networkx. The get_knowledge_graph for neo4j existed before I wrote the webui, and the get_knowledge_graph for mongo was written by me using AI. Sorry, I don't have the ability to implement get_knowledge_graph for other backends.

Yes. Once I finish handling my graduation-related tasks, I will prioritize implementing the get_knowledge_graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants