优化模组翻译匹配 #3231
Open
优化模组翻译匹配 #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决特殊情况：`EntityCulling`与`Entity Culling `
This comment was marked as outdated.
This comment was marked as outdated.
Closed
yushijinhun
reviewed
Jan 8, 2025
|
|
||
| return modIdMap.get(id); | ||
| String filteredName = name.replaceAll("[^a-zA-Z0-9]", ""); |
There was a problem hiding this comment.
去掉除英文字母和数字的字符进行匹配，modSubnameMap 中的内容也是过滤后的内容
|
我觉得用 subname 匹配不是个好主意。mod_data.txt 的 13825 个条目中，有 7769 个条目都没有 subname。 分析 mod_data.txt 可以发现：
因此，比较好的匹配方法可能是 同时匹配 modid 和 subname。 |
zkitefly
commented
Jan 12, 2025
Comment on lines
+91
to
+100
| if (StringUtils.isNotBlank(subname)) { | ||
| String filteredSubName = "subname-" + subname.replaceAll("[^a-zA-Z]", ""); | ||
| return modMap.get(filteredSubName); | ||
| } | ||
|
|
||
| if (StringUtils.isNotBlank(id)) { | ||
| return modMap.get(id); | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
@yushijinhun 已改成优先使用 subname 匹配，如果没有 subname 则使用 id 进行匹配
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原理是更换成本地模组 name 和 mod_data.txt 的 subname 进行配对，因为这俩很多模组都是匹配的
顺便搞定了没有中文就不显示的情况