Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Change log_reference_length to log_reference_params #34

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

3m1n3nc3
Copy link
Contributor

This pull request allows passing additional parameters to the log reference generator.

3m1n3nc3 added 2 commits June 27, 2024 14:08
…passing additional parameters to the log reference generator
…passing additional parameters to the log reference generator
@HPWebdeveloper
Copy link
Owner

Please open the access then I can modify some comments :)

@3m1n3nc3
Copy link
Contributor Author

Please open the access then I can modify some comments :)

How do I do that?

@HPWebdeveloper
Copy link
Owner

HPWebdeveloper commented Jun 27, 2024

Please open the access then I can modify some comments :)

How do I do that?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

edit the existing pull request to enable maintainer access.

Enable Edit Access: On the right-hand side of the pull request page, you should look for the checkbox labeled "Allow edits from maintainers." If it's not already checked, you need to check this box.

@3m1n3nc3
Copy link
Contributor Author

Please open the access then I can modify some comments :)

How do I do that?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

edit the existing pull request to enable maintainer access.

Enable Edit Access: On the right-hand side of the pull request page, you should look for the checkbox labeled "Allow edits from maintainers." If it's not already checked, you need to check this box.

image The option appears to be missing here

@HPWebdeveloper
Copy link
Owner

Ok,

@3m1n3nc3
Copy link
Contributor Author

Ok,

Is there something else I can do?

@HPWebdeveloper HPWebdeveloper merged commit 3bdf40c into HPWebdeveloper:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants