Plugin registry implementation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amete
reviewed
Jun 2, 2020
amete
added
the
work in progress
graeme-a-stewart
removed
the
work in progress
|
Hi @amete - so I think this in good shape to me merged now, if you approve of the changes |
Proof-of-concept with one component using the https://github.com/psalvaggio/cppregpattern implementation
Get rid of some of the generic macros that we do not need Add a description map that allows components to describe themselves
In our case the class name can always be used
Each monitor registers itself in its header Main program loops over registered monitors to initialise
Much less hacky for getting the wallmon pointer that is needed in the main loop Cleanup some unused headers
graeme-a-stewart
force-pushed
the
plugin-registry
branch
from
466faad to
7afe10e
Compare
|
Hi @graeme-a-stewart, Do we really want to return a raw pointer w/ |
|
That's a good point! Yes, let me try to make that change then. |
In prmon we don't have need for returning anything else, so safer to embed this deeper into the code
amete
approved these changes
Jun 4, 2020
|
All looks good to me, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not quite finished in it's full implementation, but it is a good time for review as further development comes on top.
Inspired by https://github.com/psalvaggio/cppregpattern this is a registry implementaion for prmon.
It makes the code in the main monitor look a lot nicer, as initialisation is now a loop over the registry. I am not completely happy with the pointer grabbed to
wallmon, but as it's used inside the monitoring loop (to pass wallclock time to the average stats generation) it is needed and I could not think of a better way.Closes #113
Helps with making #106 and #107 much easier to implement