Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily downgrade favicons-webpack-plugin #3072

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

optionsome
Copy link
Member

Proposed Changes

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #3072 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3072   +/-   ##
======================================
  Coverage    61.2%   61.2%           
======================================
  Files         288     288           
  Lines        7514    7514           
======================================
  Hits         4599    4599           
  Misses       2915    2915

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb3dd5...4d2d78f. Read the comment docs.

@vesameskanen vesameskanen merged commit 0c16a92 into master Jan 29, 2020
@vesameskanen vesameskanen deleted the downgrade-favicons-plugin branch January 29, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants