Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-3417 #3148

Merged
merged 21 commits into from
Apr 1, 2020
Merged

DT-3417 #3148

merged 21 commits into from
Apr 1, 2020

Conversation

AleksiSiitari
Copy link
Contributor

Proposed Changes

  • add U prefix to U bus lines in the

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@AleksiSiitari AleksiSiitari changed the title feat: add U prefix to U bus lines DT-3417 Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #3148 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   61.84%   61.81%   -0.03%     
==========================================
  Files         287      287              
  Lines        7370     7375       +5     
==========================================
+ Hits         4558     4559       +1     
- Misses       2812     2816       +4
Impacted Files Coverage Δ
app/component/RouteHeader.js 16.66% <ø> (ø) ⬆️
app/component/NextDeparturesList.js 8.33% <ø> (ø) ⬆️
app/component/RouteNumberContainer.js 92.3% <ø> (ø) ⬆️
app/component/CallAgencyLeg.js 33.33% <ø> (ø) ⬆️
app/component/ViaLeg.js 70.58% <ø> (ø) ⬆️
app/component/RoutePage.js 67.36% <ø> (ø) ⬆️
app/component/TransitLeg.js 70.96% <ø> (ø) ⬆️
app/component/SummaryRow.js 86.66% <ø> (ø) ⬆️
app/configurations/config.default.js 92.3% <0%> (-7.7%) ⬇️
app/configurations/config.hsl.js 72.72% <0%> (-27.28%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53899f...c71db8e. Read the comment docs.

@vesameskanen vesameskanen self-assigned this Mar 30, 2020
@vesameskanen
Copy link
Member

vesameskanen commented Mar 30, 2020

  • Route page header layout breaks on 5 digit route names (try searching 955A)
  • Stop / station page layout breaks. 'Linja' column clips long route ids like U955A. Try ' hki linja-autoasema 1215'. Same problem in Linja/Laituri view, too.
  • Change mapRouting func name, it is too generic. 'getRoutePrefix' might be better.
  • Do we need to introduce config as ContextType in NextDeparturesList.js and some other components whic do not refer to it at all?
  • Default config should not add any prefix. Always return empty string'' from prefix func. U is HSL only.

@vesameskanen vesameskanen merged commit 12aa7d6 into master Apr 1, 2020
@vesameskanen vesameskanen deleted the dt-3417 branch April 1, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants