Line with SerializedHierarchy #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxbotix
changed the title
tuxbotix
force-pushed
the
serialized_hierarchy_for_line
branch
from
4a5ef39
to
0849440
Compare
knoellle
requested changes
Apr 20, 2024
@knoellle I forgot to mention, #797 can kill this MR as that introduces A workaround option is to add |
|
Superseded by #987 |
auto-merge was automatically disabled
May 5, 2024 18:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
It relates to #147, but Fixing
Linefirst.I'm not convinced if the naming is the best, but 0 or 1 are invalid field names making them impossible to use.
Fixes #
ToDo / Known Issues
..
Ideas for Next Iterations (Not This PR)
Complete coverage for : #147
Or find an alternative approach to handle Tuple structs with SerializedHierarchy!
How to Test
Describe how to test your changes. (For the reviewer)