Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tarun bio #44

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Tarun bio #44

merged 2 commits into from
Feb 2, 2024

Conversation

tarunpurswani
Copy link
Contributor

@tarunpurswani tarunpurswani commented Feb 2, 2024 •
edited
Loading

Checklists

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)
  • I wrote my markdown locally on a new branch
  • My bio file is named exactly the same as my GitHub username
  • My bio link in the class README opens to my student bio file
  • I pulled and merged main into my branch before pushing
  • I pushed my branch to the class repository and opened a PR
  • I went through the PR checklist
  • All the CI check pass
  • I assigned a coach to review my PR

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work
  • any embedded code snippets are formatted

@tarunpurswani tarunpurswani self-assigned this Feb 2, 2024
@tarunpurswani tarunpurswani added this to the 1. Workflows milestone Feb 2, 2024
galalkoro98
galalkoro98 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@galalkoro98 galalkoro98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well don :)

@galalkoro98 galalkoro98 merged commit 0873659 into main Feb 2, 2024
1 check passed
@tarunpurswani tarunpurswani linked an issue Feb 2, 2024 that may be closed by this pull request
Tarun : Workflows : Student-Bio #47
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galalkoro98 galalkoro98 galalkoro98 approved these changes

@sammou00 sammou00 Awaiting requested review from sammou00

@Mileenka Mileenka Awaiting requested review from Mileenka

@Hekterek Hekterek Awaiting requested review from Hekterek

Assignees

@tarunpurswani tarunpurswani

Labels
indvidual
Projects
None yet
Milestone
1. Workflows
Development

Successfully merging this pull request may close these issues.

Tarun : Workflows : Student-Bio
2 participants
@tarunpurswani @galalkoro98