Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix - Editions #501

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Bugfix - Editions #501

merged 13 commits into from
Jul 17, 2024

Conversation

IGORnvk
Copy link
Collaborator

@IGORnvk IGORnvk commented Jul 10, 2024 •
edited
Loading

Description

Reworked editions logic based on the feedback from the demo. Just test and see.

closes #480 #490 #504

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

What needs to be tested

After migrating and seeding, as an event organizer:

  • Try acessing any other moderator route, such as: /schedule and verify that it redirects to moderator/editions if there is no active edition.
  • Try the same with other roles (e.g. participant can't access any mod routes). Basically double check if all the routes are protected.
  • Verify that there is a badge next to Editions in sidemenu.
  • Click on the edition.
  • Set dates of both edition and events and verify that you can't make an edition "during the year Jesus was born". Try to break date inputs as much as possible.
  • Activate the edition.
  • Add/Edit keynote speaker on the show page of the edition.
  • Verify that you can access other moderator routes once the edition is activated.
  • Create new edition.
  • Delete edition.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@IGORnvk IGORnvk added feature New feature or request high priority frontend issues/features related to the frontend backend issues/features related to the backend crew crew dashboard labels Jul 10, 2024
@IGORnvk IGORnvk self-assigned this Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Coverage report for commit: 37690e6
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 70.5%
  10% │ ██░░░░░░░░░░░░░░░░░░░░░ │  3.1%
  20% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.0%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.6%
  40% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.0%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.5%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.5%
  70% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.5%
  80% │ ██░░░░░░░░░░░░░░░░░░░░░ │  3.1%
  90% │ ██░░░░░░░░░░░░░░░░░░░░░ │  3.1%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.0%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 30.05% | Methods: 24.66%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php90.24%25.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php75.00%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Actions/Schedule
   PresentationAllocationHelper.php--100.00%
   PresentationConflictChecker.php--100.00%
   ResetSchedule.php--100.00%
app/Console/Commands
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ApproveLastCreatedCompany.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   ModifyTimeslotDuration.php--100.00%
   SyncPermissions.php100.00%100.00%100.00%
   UpsertMasterData.php73.91%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php100.00%100.00%100.00%
   InvitationController.php--100.00%
   PresentationController.php--100.00%
   ProgrammeController.php--100.00%
   RegistrationController.php25.00%-100.00%
   SpeakerController.php--100.00%
app/Http/Controllers/Crew
   BoothController.php91.11%83.33%100.00%
   CompanyController.php96.74%75.00%100.00%
   CrewController.php--100.00%
   DefaultPresentationController.php100.00%100.00%100.00%
   EditionController.php--100.00%
   PresentationController.php90.20%66.67%100.00%
   RoomController.php88.00%80.00%100.00%
   ScheduleController.php--100.00%
   SponsorshipController.php94.83%66.67%100.00%
   UserController.php--100.00%
app/Http/Controllers/Hub
   CompanyController.php--100.00%
   ParticipantController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Http/Middleware
   EditionMiddleware.php33.33%-100.00%
app/Http/Requests
   StorePresentationRequest.php100.00%100.00%100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
   NotificationsList.php--100.00%
app/Livewire/Booth
   DeleteBoothModal.php--100.00%
   EditBoothModal.php--100.00%
   JoinBoothOwnerModal.php--100.00%
app/Livewire/Company
   AddMember.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DeleteCompanyModal.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Edition
   ActivateEditionModal.php--100.00%
   AddKeynoteModal.php--100.00%
   DeleteEditionModal.php--100.00%
   EditEditionModal.php--100.00%
app/Livewire/EditionEvent
   EditEditionEventModal.php--100.00%
app/Livewire/Forms
   BoothForm.php--100.00%
   CompanyForm.php--100.00%
   DefaultPresentationForm.php--100.00%
   EditionEventForm.php--100.00%
   EditionForm.php--100.00%
   KeynoteForm.php--100.00%
   PresentationForm.php--100.00%
   RoomForm.php--100.00%
app/Livewire/Presentation
   DeletePresentationModal.php--100.00%
   EditPresentationModal.php--100.00%
   JoinAsSpeakerModal.php--100.00%
   UploadPresentation.php--100.00%
app/Livewire/Registration
   CompanyBasicForm.php8.33%25.00%100.00%
   CompanyInternshipsForm.php14.29%33.33%100.00%
   CompanyLocationForm.php10.00%33.33%100.00%
   CompanyMotivationForm.php16.67%33.33%100.00%
   CompanyRepresentativeForm.php7.69%33.33%100.00%
   ParentComponent.php2.44%25.00%100.00%
   SelectCountryCode.php25.00%28.57%100.00%
app/Livewire/Room
   DeleteRoomModal.php--100.00%
   EditRoomModal.php--100.00%
app/Livewire/Schedule
   AddDefaultPresentation.php--100.00%
   Cell.php--100.00%
   ConfirmResetScheduleModal.php--100.00%
   DefaultPresentation.php--100.00%
   EditDefaultPresentationModal.php--100.00%
   GridParentComponent.php--100.00%
   Presentation.php--100.00%
   PresentationModal.php--100.00%
   PublishProgrammeButton.php--100.00%
   PublishProgrammeModal.php--100.00%
app/Livewire/Sponsorship
   DeleteSponsorshipModal.php--100.00%
app/Livewire/Users
   UserFilteringList.php--100.00%
app/Mail
   BoothApprovedMailable.php100.00%100.00%100.00%
   BoothDisapprovedMailable.php--100.00%
   CancelledPresentationMailable.php--100.00%
   CompanyApprovedMailable.php100.00%100.00%100.00%
   CompanyDisapprovedMailable.php100.00%100.00%100.00%
   CompanyRepInvitation.php100.00%100.00%100.00%
   CustomCompanyInvitation.php--100.00%
   FinalProgrammeReleasedMailable.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   SponsorshipApprovedMailable.php100.00%100.00%100.00%
   SponsorshipDisapprovedMailable.php100.00%100.00%100.00%
   UserInvitation.php--100.00%
app/Models
   Booth.php80.00%50.00%100.00%
   Company.php81.97%68.75%100.00%
   DefaultPresentation.php--100.00%
   Difficulty.php--100.00%
   Edition.php21.43%35.71%100.00%
   EditionEvent.php--100.00%
   Event.php--100.00%
   FrequentQuestion.php100.00%100.00%100.00%
   InternshipAttribute.php75.00%75.00%100.00%
   Invitation.php25.00%33.33%100.00%
   Presentation.php55.13%55.56%100.00%
   Room.php50.00%50.00%100.00%
   Sponsorship.php37.50%28.57%100.00%
   Timeslot.php--100.00%
   User.php79.49%73.33%100.00%
   UserPresentation.php--100.00%
app/Notifications
   NotifyBoothApproved.php--100.00%
   NotifyBoothDisapproved.php--100.00%
   NotifyPresentationApproved.php--100.00%
   NotifyPresentationDisapproved.php--100.00%
   NotifySponsorshipApproved.php--100.00%
   NotifySponsorshipDisapproved.php--100.00%
   NotifyTeamApproved.php--100.00%
   NotifyTeamDisapproved.php--100.00%
app/Observers
Table truncated to fit comment

🤖 comment via lucassabreu/comment-coverage-clover

This was linked to issues Jul 10, 2024
Bug: Event Organizer usability when it comes to creating edition #480
Closed
Bug: Add message why edition cannot be activated for better UX #490
Closed
v-stamenova
v-stamenova previously requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@v-stamenova v-stamenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit tired and just looked through it real quick but I think those are just the main stuff

app/Http/Middleware/EditionMiddleware.php Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
@IGORnvk IGORnvk linked an issue Jul 11, 2024 that may be closed by this pull request
Bug: Edition Management - Invalid datetime format #504
Closed
@TimKardol
Copy link
Collaborator

image
Frontend wise: I think it could be clearer that these are clickable

@v-stamenova v-stamenova dismissed their stale review July 16, 2024 11:25

@TimKardol already checked it and it's blocking the merge

@IGORnvk IGORnvk merged commit b1c275e into development Jul 17, 2024
2 checks passed
@IGORnvk IGORnvk deleted the bugfix/edition branch November 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimKardol TimKardol TimKardol approved these changes

@v-stamenova v-stamenova v-stamenova left review comments

@dwaard dwaard Awaiting requested review from dwaard

Assignees

@IGORnvk IGORnvk

Labels
backend issues/features related to the backend crew crew dashboard feature New feature or request frontend issues/features related to the frontend high priority
Projects
None yet
Milestone
No milestone
3 participants
@IGORnvk @TimKardol @v-stamenova