-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Better design crew index pages #559
Merged
TimKardol
merged 9 commits into
development
from
feature/556-better-design-crew-index-pages
Oct 23, 2024
Merged
Feature - Better design crew index pages #559
TimKardol
merged 9 commits into
development
from
feature/556-better-design-crew-index-pages
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-stamenova
added
frontend
issues/features related to the frontend
crew
crew dashboard
labels
Oct 16, 2024
Oh that's weird. I think using the default icons will be best since either way the logos are a bit squashed and not very pretty |
TimKardol
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch introduces design changes on the index pages for the crew. The general layout of the list of entities is changed (now it's made under table) to help with providing more details. Also now the view of the route
moderator.companies.show
includes the presentations of the company.closes #556
Type of change
What needs to be tested
crew.companies.index
and ensure that the data needed is therecrew.presentations.index
and ensure that the data needed is therecrew.booths.index
and ensure that the data needed is therecrew.sponsorships.index
and ensure that the data needed is therecrew.rooms.index
and ensure that the data needed is therecrew.faqs.index
and ensure that the data needed is therecrew.editions.index
and ensure that the data needed is thereChecklist: