Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Notify users on presentation/company update #562

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Feature - Notify users on presentation/company update #562

merged 9 commits into from
Oct 28, 2024

Conversation

IGORnvk
Copy link
Collaborator

@IGORnvk IGORnvk commented Oct 16, 2024 •
edited by TimKardol
Loading

Description

Closes #551 and #563
Notifies crew/speaker or crew/company rep when details of the mentioned models are changed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

What needs to be tested

Presentation scenario:

  • Edit details of a presentation as crew and verify that speaker(s) received an email notification.
  • Edit details of a presentation as speaker and verify that crew (admin, assistant admin and speakers supervisor) received an email notification.
  • Delete presentation and verify that speakers got the email.

Company scenario:

  • Edit details of a company as crew and verify that company rep received an email notification.
  • Edit details of a company as company rep and verify that crew (admin and assistant admin) received an email notification.
  • Delete company and verify that company rep got the email.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Coverage report for commit: 5b5c76c
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 71.6%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.7%
  20% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.8%
  30% │ ██░░░░░░░░░░░░░░░░░░░░░ │  3.2%
  40% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.5%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  70% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.4%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.3%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 13.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 26.91% | Methods: 22.86%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php90.24%25.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php72.73%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Actions/Log
   ApprovalHandler.php95.83%50.00%100.00%
app/Actions/Permissions
   ReadPermissionConfig.php100.00%100.00%100.00%
app/Actions/Schedule
   PresentationAllocationHelper.php--100.00%
   PresentationConflictChecker.php--100.00%
   ResetSchedule.php--100.00%
app/Actions/Users
   AddParticipantToCompanyHandler.php--100.00%
app/Console/Commands
   AddParticipantToCompany.php--100.00%
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ApproveLastCreatedCompany.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   ModifyTimeslotDuration.php--100.00%
   SyncPermissions.php96.77%85.71%100.00%
   UpsertMasterData.php73.91%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   FrequentQuestionController.php--100.00%
   HomeController.php100.00%100.00%100.00%
   InvitationController.php--100.00%
   PresentationController.php--100.00%
   ProgrammeController.php--100.00%
   RegistrationController.php25.00%-100.00%
   SpeakerController.php--100.00%
app/Http/Controllers/Crew
   BoothController.php57.78%66.67%100.00%
   CompanyController.php96.74%75.00%100.00%
   CrewController.php--100.00%
   DefaultPresentationController.php100.00%100.00%100.00%
   EditionController.php--100.00%
   FrequentQuestionController.php--100.00%
   PresentationController.php86.79%66.67%100.00%
   RoomController.php88.00%80.00%100.00%
   ScheduleController.php--100.00%
   SponsorshipController.php94.44%66.67%100.00%
   UserController.php--100.00%
app/Http/Controllers/Hub
   CompanyController.php--100.00%
   ParticipantController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Http/Middleware
   EditionMiddleware.php33.33%-100.00%
app/Http/Requests
   StorePresentationRequest.php100.00%100.00%100.00%
app/Jobs
   NotifyCompanyRoles.php63.64%50.00%100.00%
   NotifyPresentationRoles.php30.00%50.00%100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   ConfirmationModal.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
   NotificationsList.php--100.00%
app/Livewire/Booth
   CreateBooth.php14.63%28.57%100.00%
   DeleteBoothModal.php--100.00%
   EditBoothModal.php--100.00%
   JoinBoothOwnerModal.php--100.00%
app/Livewire/Company
   AddMember.php--100.00%
   AddParticipant.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DeleteCompanyModal.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Crew
   AssignRoleToUser.php--100.00%
   RevokeRoleOfUser.php--100.00%
   RolePermissionsInfo.php--100.00%
app/Livewire/Edition
   ActivateEditionModal.php--100.00%
   AddKeynoteModal.php--100.00%
   DeleteEditionModal.php--100.00%
   EditEditionModal.php--100.00%
app/Livewire/EditionEvent
   EditEditionEventModal.php--100.00%
app/Livewire/Forms
   BoothForm.php--100.00%
   CompanyForm.php--100.00%
   DefaultPresentationForm.php--100.00%
   EditionEventForm.php--100.00%
   EditionForm.php--100.00%
   FrequentQuestionForm.php--100.00%
   KeynoteForm.php--100.00%
   PresentationForm.php--100.00%
   RoomForm.php--100.00%
app/Livewire/FrequentQuestions
   DeleteFrequentQuestionModal.php--100.00%
   EditFrequentQuestionModal.php--100.00%
app/Livewire/Presentation
   DeletePresentationModal.php--100.00%
   EditPresentationModal.php--100.00%
   JoinAsSpeakerModal.php--100.00%
   UploadPresentation.php--100.00%
app/Livewire/Registration
   CompanyBasicForm.php8.33%25.00%100.00%
   CompanyInternshipsForm.php14.29%33.33%100.00%
   CompanyLocationForm.php10.00%33.33%100.00%
   CompanyMotivationForm.php16.67%33.33%100.00%
   CompanyRepresentativeForm.php7.69%33.33%100.00%
   ParentComponent.php2.44%25.00%100.00%
   SelectCountryCode.php25.00%28.57%100.00%
app/Livewire/Room
   DeleteRoomModal.php--100.00%
   EditRoomModal.php--100.00%
app/Livewire/Schedule
   AddDefaultPresentation.php--100.00%
   Cell.php--100.00%
   ConfirmResetScheduleModal.php--100.00%
   DefaultPresentation.php--100.00%
   EditDefaultPresentationModal.php--100.00%
   GridParentComponent.php--100.00%
   Presentation.php--100.00%
   PresentationModal.php--100.00%
   PublishProgrammeButton.php--100.00%
   PublishProgrammeModal.php--100.00%
app/Livewire/Sponsorship
   DeleteSponsorshipModal.php--100.00%
app/Livewire/Users
   UserFilteringList.php--100.00%
app/Mail
   BoothApprovedMailable.php100.00%100.00%100.00%
   BoothDisapprovedMailable.php--100.00%
   CancelledPresentationMailable.php--100.00%
   CompanyApprovedMailable.php100.00%100.00%100.00%
   CompanyDeletedMailable.php--100.00%
   CompanyDisapprovedMailable.php100.00%100.00%100.00%
   CompanyRepInvitation.php100.00%100.00%100.00%
   CompanyUpdatedMailable.php--100.00%
   CustomCompanyInvitation.php--100.00%
   FinalProgrammeReleasedMailable.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDeletedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   PresentationUpdatedMailable.php--100.00%
   SponsorshipApprovedMailable.php100.00%100.00%100.00%
   SponsorshipDisapprovedMailable.php100.00%100.00%100.00%
   UserInvitation.php--100.00%
app/Models
   Booth.php100.00%100.00%100.00%
   Company.php75.00%68.42%100.00%
Table truncated to fit comment

🤖 comment via lucassabreu/comment-coverage-clover

@IGORnvk IGORnvk self-assigned this Oct 16, 2024
@IGORnvk IGORnvk added feature New feature or request high priority labels Oct 16, 2024
This was linked to issues Oct 22, 2024
Feature: Notify event organizer and speaker supervisor when user updates their presentation/company and vice versa #551
Closed
Feature: Send email to company rep when company is deleted #563
Closed
@TimKardol TimKardol merged commit db4ed68 into development Oct 28, 2024
2 checks passed
This was referenced Nov 5, 2024
Closed
Closed
@IGORnvk IGORnvk deleted the feature/notify-on-presentation-update branch November 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimKardol TimKardol TimKardol approved these changes

@v-stamenova v-stamenova Awaiting requested review from v-stamenova

Assignees

@IGORnvk IGORnvk

Labels
feature New feature or request high priority
Projects
None yet
Milestone
No milestone
2 participants
@IGORnvk @TimKardol