Don't compare two blank moment() for potential race condition #14974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10225
Changes
When
appearanceSets[setKey].availableUntil
isundefined
, then we were performingmoment().isBefore(moment())
and the race condition occasionally returnstrue
about 0.05-0.5% of the time (from my experience).How to test:
website/client/src/mixins/avatarEditUtilities.js
hide = this.hideSet(set);
tohide = this.hideSet(set, key);
hideSet (setKey)
tohideSet (setKey, key)
if (appearanceSets[setKey].availableFrom)
blocktrue
cases on Consoleconst tempHide = ...
with below block (which has the identical logic as this PR)true
printed out on Consolekey
above doesn't have to be'bear'
. I just wanted a key that will returnhide
to befalse
by default. You can try any key for Skin that should returnhide = false
(e.g.'rainbow'
)UUID: 662332a6-a7e7-4b70-858e-255f3e6076a8