248 add character limit on project names #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying timber with
|
| Latest commit: |
0952afb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5317635f.timber.pages.dev |
| Branch Preview URL: | https://248-add-character-limit-on-p.timber.pages.dev |
ganning127
reviewed
Jul 23, 2024
ganning127
reviewed
Jul 23, 2024
ganning127
requested changes
Jul 23, 2024
ganning127
reviewed
Jul 23, 2024
|
|
||
| <Text> | ||
| <Badge>{props.project.id}</Badge> | ||
| <Text mx={1.5} as="span">{props.project.name}</Text> |
There was a problem hiding this comment.
Can we change to ml instead of mx? Once we have char limit, we won't need right margin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added margin-left and margin-right spacing (mx) to the project Name in judgingBox. I know the issue description says to limit project name so I also limited Project Name to be 30 characters.
Is this what was expected?