Fixed fishing probabilities to account for duplicate entries, non-cat… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chable fish, furniture and non-standard IDs
Exaxxion
reviewed
Apr 7, 2024
| @@ -106,12 +106,12 @@ public static void PrintFishingInfo() | |||
|
|
|||
| LocationData thisLocData = Game1.currentLocation.GetData(); | |||
| String jThisLocData = JsonSerializer.Serialize(thisLocData, new JsonSerializerOptions { WriteIndented = true }); | |||
| Logger.Info($"This LocationData: {jThisLocData}"); | |||
| //Logger.Info($"This LocationData: {jThisLocData}"); | |||
There was a problem hiding this comment.
Leaving commented-out code around is not generally advisable.
Perhaps instead consider reducing them from Info to Trace so they are not printed to console unless you're using SMAPI for Developers, or delete them / tie them to a compile-time switch as they will still explode the log file even under Trace (see log level documentation).
Considering the massive quantity of information in these, I'd probably opt for enabling them only in a debug build. It is unkind to performance and the end user's disk to log all that during gameplay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed fishing probabilities to account for duplicate entries, non-catchable fish, furniture and non-standard IDs. Also included garbage handling. Disabled Logging entries to reduce the crazy amount of log spam as well.
This might need to be updated if there are any non-garbage fish records that use the random ID functionality, but I have not seen one so far.