Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated probability code, magic bait, expanded window and tackle display #17

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Sandman534
Copy link

@Sandman534 Sandman534 commented Apr 9, 2024

  • Updated the probability code to exclude some things that I should not have added in. Mainly Garbage.
  • Added in logic to look for all valid fish if you are using Magic Bait
  • With this, I changed the way the window is sized and it can now render multiple columns. This includes a new option to choose how many fish to show per column. Had to do this because with magic bait the available fish window can be quite long, especially with mods.
  • Added a new feature where you can see your current bait and tackle. This has a new set of options below Fish Probability and you can anchor the window wherever you want, or have it attach to the probability window
  • Also un-commented the logging functionality and put them to display only if the game is in debug mode

@Sandman534
Copy link
Author

Sandman534 commented Apr 9, 2024

Note that the new options I added into translation are google translated... I dont know any other languages.

@Sandman534
Copy link
Author

Sandman534 commented Apr 10, 2024

I also did try to add Furniture in, but there are a lot of conditions surrounding furniture, and since its all catch it once and no more... I think excluding furniture as a whole is the best idea. I'm sure there are ways to make it work, but I dont think the effort is worth the payoff...

@Hackswell Hackswell merged commit e964544 into Hackswell:develop16 Apr 23, 2024
@Hackswell
Copy link
Owner

Can you please pull the develop16 branch and ensure I didn't break the merge? Thanks.

@Hackswell
Copy link
Owner

Also, please add config option information to FeaturesAndConfigs.md, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants