Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pyinstaller support #181

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: pyinstaller support #181

merged 2 commits into from
Feb 6, 2024

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Feb 6, 2024

This PR adds preliminary support for pyinstaller. There are a couple key concerns addressed in this PR.

  • ComfyUI is packaged in hordelib releases and the PATH variable is adjusted at runtime for ComfyUI code to be located and used.
    • This is because ComfyUI is not a library and is accordingly not laid out as one.
    • PyInstaller needs hooks defined for discovery to happen appropriately during a build and the appropriate files located. See the official PyInstaller docs on hooks for more information about this.
  • The third-party nodes which are also packaged work in a "normal" pip install but do not work in a PyInstaller build because implicit namespacing and other python import behavior do not carry over.
    • Of note, most of the files changes in this PR simply change imports to a "fully qualified" import, which accounts for the fact that the custom node code is not in its own package (per se) but packaged and shipped within the hordelib folder itself.

@tazlin tazlin merged commit 1b19074 into main Feb 6, 2024
1 check passed
@tazlin tazlin deleted the pyinstaller branch February 6, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant