[core] Fixed formal problems detected by clang

Haivision · Dec 11, 2020 · 0add6cc · 0add6cc
1 parent 0a61cb9
commit 0add6cc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/srtcore/common.h b/srtcore/common.h
@@ -771,7 +771,7 @@ class RollNumber
         return right < *this;
     }
 
-    bool operator=(const this_t& right) const
+    bool operator==(const this_t& right) const
     {
         return number == right.number;
     }

diff --git a/srtcore/core.cpp b/srtcore/core.cpp
@@ -9668,8 +9668,10 @@ int CUDT::processData(CUnit* in_unit)
         std::string s = tns1.str();
         tns2 << "SRT:TsbPd:@" << s.substr(s.size()-2, 2);
 
-        ThreadName tn(tns2.str().c_str());
-        const char* thname = tns2.str().c_str();
+        const string& tn = tns2.str();
+
+        ThreadName tnkeep(tn.c_str());
+        const char* thname = tn.c_str();
 #else
         const char* thname = "SRT:TsbPd";
 #endif