Skip to content

Commit

Permalink
[core] Fix extra ACK sent after a connection is established (#2832)
Browse files Browse the repository at this point in the history
(uninitialized variable).
  • Loading branch information
yomnes0 committed Dec 20, 2023
1 parent 5f57dde commit 79ab5f5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion srtcore/core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ void srt::CUDT::construct()
m_bTsbPdAckWakeup = false;
m_bGroupTsbPd = false;
m_bPeerTLPktDrop = false;
m_bBufferWasFull = false;

// Initilize mutex and condition variables.
initSynch();
Expand Down Expand Up @@ -3555,7 +3556,6 @@ void srt::CUDT::startConnect(const sockaddr_any& serv_addr, int32_t forced_isn)
m_iISN = m_ConnReq.m_iISN = forced_isn;

setInitialSndSeq(m_iISN);

// Inform the server my configurations.
CPacket reqpkt;
reqpkt.setControl(UMSG_HANDSHAKE);
Expand Down
1 change: 0 additions & 1 deletion srtcore/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,6 @@ class CUDT

CallbackHolder<srt_listen_callback_fn> m_cbAcceptHook;
CallbackHolder<srt_connect_callback_fn> m_cbConnectHook;

// FORWARDER
public:
static int installAcceptHook(SRTSOCKET lsn, srt_listen_callback_fn* hook, void* opaq);
Expand Down

0 comments on commit 79ab5f5

Please sign in to comment.