Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTAIN] Move socket group code to a separate source file #1258

Closed
maxsharabayko opened this issue Apr 24, 2020 · 0 comments · Fixed by #1483
Closed

[MAINTAIN] Move socket group code to a separate source file #1258

maxsharabayko opened this issue Apr 24, 2020 · 0 comments · Fixed by #1483
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.4.2

Comments

@maxsharabayko
Copy link
Collaborator

The core.cpp source file is getting bigger and exceeds 15k of lines.
Consider moving socket group functionality to a separate module to improve localization of different logics.
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Apr 24, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Apr 24, 2020
@maxsharabayko maxsharabayko modified the milestones: v1.5.0, v1.5.1 Jul 27, 2020
@maxsharabayko maxsharabayko mentioned this issue Aug 17, 2020
Merged
@mbakholdina mbakholdina modified the milestones: v1.5.1, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging a pull request may close this issue.

Moved socket group code to separate files maxsharabayko/srt
2 participants
@maxsharabayko @mbakholdina