Moved socket group code to separate files #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
maxsharabayko
commented
Aug 18, 2020
maxsharabayko
force-pushed
the
develop/split-socket-group
branch
from
d907ab6 to
99db85e
Compare
maxsharabayko
force-pushed
the
develop/split-socket-group
branch
from
99db85e to
50a93e7
Compare
ethouris
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To split the logic of an individual SRT socket and a group of sockets the group-related code is moved to
group.handgroup.cpp.CUDTGroupclass moved to group.h and group.cppPacketMetricis moved to common.hstatic bool getOptDefault(..)and related templates are moved to group.cppcast_optval<..>are moved to core.h and made inlineSRT_DEF_VERSIONmarked asexternto use it ingroup.cpp.Fixes #1258