Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Initially lost packets may be ignored in group message mode #2236

Closed
gou4shi1 opened this issue Jan 27, 2022 · 1 comment · Fixed by #2257
Closed

[BUG] Initially lost packets may be ignored in group message mode #2236

gou4shi1 opened this issue Jan 27, 2022 · 1 comment · Fixed by #2257
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@gou4shi1
Copy link
Contributor

Describe the bug
need_notify_loss in CUDT::processData() will be set to false for the first received packet (because the group recv state is transiting to RUNNING).

To Reproduce

  1. Callers broadcast inorder messages to receivers.
  2. The first packet is dropped by iptable.
  3. The following packets are received and the receiver ack with largest_received_seq+1 since the first lost packet is ignored by !need_notify_loss.
  4. Group::recv() fail to read a inorder message since the first packet is lost forever.

Expected behavior
I know that if TLPKTDROP is enabled, it should be fine, but in message mode, all lost packets with TTL=-1 should not be ignored.

Desktop:

@gou4shi1 gou4shi1 added the Type: Bug Indicates an unexpected problem or unintended behavior label Jan 27, 2022
@gou4shi1 gou4shi1 changed the title [BUG] initial lost packets may be ignored in group message mode [BUG] Initially lost packets may be ignored in group message mode Jan 27, 2022
@gou4shi1
Copy link
Contributor Author

It seems to be introduced by #1448 but I don't know what exactly "runaway train effect" means, is need_notify_loss mainly for backup links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants