[core] refactor Group::recv() base on new rcv buffer to support message mode #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gou4shi1
force-pushed
the
fix-group-recv-in-message-mode-part-3
branch
2 times, most recently
from
ec70494
to
9f6e247
Compare
This comment has been minimized.
This comment has been minimized.
gou4shi1
force-pushed
the
fix-group-recv-in-message-mode-part-3
branch
3 times, most recently
from
f77422b
to
2660da5
Compare
gou4shi1
force-pushed
the
fix-group-recv-in-message-mode-part-3
branch
3 times, most recently
from
4ff6c62
to
aa5c27c
Compare
gou4shi1
force-pushed
the
fix-group-recv-in-message-mode-part-3
branch
from
aa5c27c
to
762cbe3
Compare
maxsharabayko
added
[core]
maxsharabayko
added a commit
to maxsharabayko/srt
that referenced
this pull request
Feb 7, 2022
Broken after merging Haivision#2218
maxsharabayko
added a commit
that referenced
this pull request
Feb 7, 2022
Broken after merging #2218
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #2046.
Fix #2138 btw.
Group::recv()does not support to read a message that across multiple packets.Group::recv()from 500+ lines to 100+ lines.