[core] Fixed group read-ready epoll events. #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
reviewed
Jul 18, 2023
gou4shi1
reviewed
Jul 18, 2023
maxsharabayko
force-pushed
the
hotfix/group-read-ready
branch
from
ac34b1c
to
03d6a3e
Compare
maxsharabayko
commented
Jul 19, 2023
| CUDTSocket* ps = *si; | ||
| if (!ps->core().isRcvBufferReady()) | ||
|
|
||
| if (!ps->core().isRcvBufferReadyNoLock()) |
There was a problem hiding this comment.
This sets a member socket state to false, doesn't it?
ethouris
approved these changes
Jul 20, 2023
maxsharabayko
commented
Aug 1, 2023
maxsharabayko
force-pushed
the
hotfix/group-read-ready
branch
from
03d6a3e
to
4db8260
Compare
maxsharabayko
force-pushed
the
hotfix/group-read-ready
branch
from
4db8260
to
69d1bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs found.
The function was introduced (changed) in v1.5.0 with the new receiver buffer in PR #2218. Maybe v1.5.0 with the old receiver buffer or earlier SRT versions didn't have this read-ready issue. In any case, there might have been other issues with the previous reading function.
TODO
CUDTGroup::m_Positionsis no longer used. Remove.group_read_seq.