Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building on Debian GNU/kFreeBSD #2253

Closed
florianernst opened this issue Feb 28, 2022 · 2 comments · Fixed by #2255
Closed

Allow building on Debian GNU/kFreeBSD #2253

florianernst opened this issue Feb 28, 2022 · 2 comments · Fixed by #2255
Labels
[build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior
Milestone
v1.5.0

Comments

@florianernst
Copy link

Hello all,

there is a Debian port to a FreeBSD kernel, and the small patch below allows building srt on it:

Index: libsrt/srtcore/utilities.h
===================================================================
--- libsrt.orig/srtcore/utilities.h
+++ libsrt/srtcore/utilities.h
@@ -115,7 +115,7 @@ written by

 #      include <sys/endian.h>

-#elif defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)
+#elif defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(__FreeBSD_kernel__)

 #      include <sys/endian.h>

This patch was initially created by Laurent Bigonville bigon@debian.org for Debian.

Cheers,
Flo
@maxsharabayko maxsharabayko added [build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior labels Mar 2, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Mar 2, 2022
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Mar 2, 2022
@maxsharabayko @bigon
[build] Fix build on Debian
9b3dcc5 
Taken from https://sources.debian.org/src/srt/1.4.2-2/debian/patches/ftbfs_kfreebsd.patch/
See Haivision#2253

Co-authored-by: Laurent Bigonville <bigon@debian.org>
@maxsharabayko maxsharabayko mentioned this issue Mar 2, 2022
Merged
@maxsharabayko
Copy link
Collaborator

Hi @florianernst
Thanks for sharing! I could put you in co-authors of PR #2255 as the one who shared the word if you write your GitHub e-mail (DM or here).

@florianernst
Copy link
Author

Hi @maxsharabayko,

well, I merely forwarded some work done by Laurent Bigonville bigon@debian.org, so rather mention him instead. ;-)

Heh, I must say #2255 is named slightly misleading as srt built fine on Debian even without that patch, it was just the specific (not fully official) port of Debian to the FreeBSD kernel where it failed. But that's mostly nitpicking.

Either way, thanks for taking care that quickly, much appreciated.

maxsharabayko added a commit that referenced this issue Mar 3, 2022
@maxsharabayko @bigon
[core] Fix build for FreeBSD kernel (#2255)
f15d300 
Taken from https://sources.debian.org/src/srt/1.4.2-2/debian/patches/ftbfs_kfreebsd.patch/
See #2253

Co-authored-by: Laurent Bigonville <bigon@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

[build] Fix build on Debian maxsharabayko/srt
2 participants
@florianernst @maxsharabayko