Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'false' value is implicitly cast to the integer type. #2372

Closed
marakew opened this issue Jun 12, 2022 · 0 comments · Fixed by #2375
Closed

The 'false' value is implicitly cast to the integer type. #2372

marakew opened this issue Jun 12, 2022 · 0 comments · Fixed by #2375
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.5.1

Comments

@marakew
Copy link

marakew commented Jun 12, 2022

srt/srtcore/core.cpp

Line 1370 in 8d1643e

return false;

should return 0; instead return false;
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Jun 13, 2022
@maxsharabayko
[core] Fixed 'false' value implicitly casting to an integer.
09e76b4 
Also some other minor warnings.
Fixes Haivision#2372.
@maxsharabayko maxsharabayko mentioned this issue Jun 13, 2022
Merged
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Jun 13, 2022
@maxsharabayko
[core] Fixed 'false' value implicitly casting to an integer.
ead71bd 
Handle handling failure of fillHsExtKMRSP(..).
Fixed some other minor conversion warnings.
Fixes Haivision#2372.
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Jun 13, 2022
@maxsharabayko
[core] Fixed 'false' value implicitly casting to an integer.
39c5f6e 
Handle handling failure of fillHsExtKMRSP(..).
Fixed some other minor conversion warnings.
Fixes Haivision#2372.
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Jun 13, 2022
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Jun 13, 2022
@maxsharabayko maxsharabayko modified the milestones: v1.5.0, Next Release Jun 15, 2022
maxsharabayko added a commit that referenced this issue Jun 15, 2022
@maxsharabayko
[core] Fixed 'false' value implicitly casting to an integer.
88aab43 
Handle handling failure of fillHsExtKMRSP(..).
Fixed some other minor conversion warnings.
Fixes #2372.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging a pull request may close this issue.

Fixed some warning maxsharabayko/srt
2 participants
@marakew @maxsharabayko