Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRT:SndQ:w thread does not tick THREADCHECK watchdog if it does not block #2668

Closed
jeandube opened this issue Feb 15, 2023 · 0 comments · Fixed by #2669
Closed

SRT:SndQ:w thread does not tick THREADCHECK watchdog if it does not block #2668

jeandube opened this issue Feb 15, 2023 · 0 comments · Fixed by #2669
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Milestone
v1.5.2

Comments

@jeandube
Copy link
Collaborator

A high bitrate (120mbpsUHD) live test case causes the THREADCHECK watchdog to trigger in the SRT:SndQ:w thread, looking like it is blocked.

A call to INCREMENT_THREAD_ITERATIONS() is missing from the thread loop, ticking the watchdog only upon THREAD_RESUME() when it blocks waiting for non-empty queue. Behavior suggest test case causes the queue to remain un-empty for too long for the watchdog.

Fix was tested and confirmed. PR in progress.
@jeandube jeandube added the Type: Bug Indicates an unexpected problem or unintended behavior label Feb 15, 2023
jeandube added a commit to jeandube/srt that referenced this issue Feb 15, 2023
@jeandube
Issue Haivision#2668: Added missing thread watchdog ticks in 3 thread…
47f8b26 
… loop.
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core and removed Type: Bug Indicates an unexpected problem or unintended behavior labels Feb 16, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Feb 16, 2023
@maxsharabayko maxsharabayko mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging a pull request may close this issue.

Added missing thread watchdog ticks in 3 thread loop. jeandube/srt
2 participants
@maxsharabayko @jeandube