API: Check optlen for string OPTIONS (e.g. SRTO_STREAMID).

[maxsharabayko]

Bug Description

Negative option lengths are not checked in srt_setsockopt() calls, except for those having integer types.

A memcpy with the to unsigned converted negative value is being done then.

To Reproduce

srt_setsockopt(SRTO_STREAMID, ..., -1 /*optlen*/);

Expected behavior

Report SRT_EINVPARAM.

TODO

• Handle invalid optlen values where not handled.
• Add a unit test to validate the expected behavior.

[yomnes0]

PR #2849 should address this by returning SRT_EINVPARAM whenever optlen is set to -1

[ethouris]

Wait. What was the final decision then?

Note that there are already applications that RELY on that setting a string-typed option with passing -1 as length treats the string as a NUL-terminated array of characters.

[maxsharabayko]

The majority has voted for not using optlen=-1 (7 votes against using, only 2 support).
The "feature" is only implemented for SRTO_BINDTODEVICE and SRTO_CONGESTION and not documented officially. Thus may be considered as a bug and safely fixed without breaking the API/ABI backward compatibility.

[ethouris]

Ah, in that case, it should be ok.

[jlsantiago0]

Perhaps using -1 or size can also help solve #2284

[maxsharabayko]

@jlsantiago0
#2284 has been already fixed by #2804.

[maxsharabayko]

Fixed by #2849.