Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Group start time and sequences are not properly set #2941

Closed
maxsharabayko opened this issue Apr 24, 2024 · 0 comments
Closed

[BUG] Group start time and sequences are not properly set #2941

maxsharabayko opened this issue Apr 24, 2024 · 0 comments
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@maxsharabayko
Copy link
Collaborator

When a group connection is established on a listening socket, the group start time is not properly set. This results, in particular, in a wrong Timestamp in SRT stats takes from a group.

Is looks like the following variables are not set with the first connection established:

  • m_tsStartTime
  • m_tsRcvPeerStartTime
  • m_iLastSchedSeqNo
  • m_iLastSchedMsgNo
  • m_RcvBaseSeqNo

See CUDT::makeMePeerOf(..) function call. The CUDT::synchronizeWithGroup(..) is nevercalled for a listener accepting a group connection, even for the second one.

To reproduce:

(improper group initialization here)
srt-xtransmit receive "srt://:4200?groupconnect=1" "srt://:5200?groupconnect=1"

srt-xtransmit generate srt://127.0.0.1:4200 srt://127.0.0.1:5200 --sendrate 5Mbps
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Apr 24, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 24, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Apr 26, 2024
maxsharabayko added a commit to maxsharabayko/srt that referenced this issue Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant