Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add srt_getversion API function #1024

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Dec 17, 2019

  • Added uint32_t srt_getversion();
  • Added description to the API docs
  • Added usage in apps

Fixes partially #1016 (does not provide a git commit info)

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core labels Dec 17, 2019
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Dec 17, 2019
Copy link
Collaborator

@jeandube jeandube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is what I expected get the installed library version number without the need to establish a connection.

srtcore/srt_c_api.cpp Outdated Show resolved Hide resolved
docs/API-functions.md Outdated Show resolved Hide resolved
srtcore/srt_c_api.cpp Outdated Show resolved Hide resolved
docs/API-functions.md Outdated Show resolved Hide resolved
@maxsharabayko
Copy link
Collaborator Author

@jeandube @ethouris
A 32-bit integer value still has 8 bits unused: 0x..XXYYZZ
What do you think if we use it for the first 8 bits of git commit ID?

@ethouris
Copy link
Collaborator

8 bits gives you 2 hex ciphers. For a git commit ID you need at least 7 hex ciphers. I think we'd better create some more elaborate version id function that can return various things depending on a tag. Might even embrace particular features.

@maxsharabayko maxsharabayko merged commit 5ef0056 into Haivision:master Mar 5, 2020
@maxsharabayko maxsharabayko deleted the develop/version branch March 5, 2020 16:39
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants