Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed legacy UDT_EPOLL_* symbols #1077

Merged

Conversation

ethouris
Copy link
Collaborator

No description provided.

@ethouris ethouris self-assigned this Jan 21, 2020
@ethouris ethouris added [core] Area: Changes in SRT library core Impact: Low Priority: High Type: Maintenance Work required to maintain or clean up the code labels Jan 21, 2020
@ethouris ethouris added this to the v1.5.0 milestone Jan 21, 2020
@maxsharabayko
Copy link
Collaborator

@ethouris Given that they are replaced, do you think we still have to preserve those in udt.h?

#define UDT_EPOLL_OPT SRT_EPOLL_OPT
#define UDT_EPOLL_IN SRT_EPOLL_IN
#define UDT_EPOLL_OUT SRT_EPOLL_OUT
#define UDT_EPOLL_ERR SRT_EPOLL_ERR

@ethouris
Copy link
Collaborator Author

Yes, we need to get rid of legacy symbols only when we are certain no one is using them any longer. The problem is that these symbols are public, so removal of them is not so simple process.

@maxsharabayko
Copy link
Collaborator

Ok, created a small note in #994. Maybe worth removing the UDT API. To be discussed later.

@ethouris
Copy link
Collaborator Author

It would be also nice to provide a real-world C++ API for SRT, but we need lots of refactoring in the base code structure first. There's some usefulness of the complementary C++ API, and it's now merged together with the legacy UDT API, which is still in use in many apps.

@maxsharabayko
Copy link
Collaborator

maxsharabayko commented Jan 21, 2020

@ethouris

... the legacy UDT API, which is still in use in many apps.

Are we aware of any of those uses of SRT via the UDT API?

@ethouris
Copy link
Collaborator Author

I doubt about any apps in the open source world. Rather some of the older code among Haivision products. We'd have to get signal from all devel teams using SRT that they no longer use any old UDT-based API, or at least aren't going to upgrade SRT to a newer version.

@maxsharabayko maxsharabayko merged commit 166253d into Haivision:master Jan 21, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: High Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants