Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for SRT bonding #1123

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Feb 7, 2020

No description provided.

@ethouris ethouris assigned ethouris and maxsharabayko and unassigned ethouris Feb 7, 2020
@ethouris ethouris added [docs] Area: Improvements or additions to documentation Priority: High Type: Maintenance Work required to maintain or clean up the code labels Feb 7, 2020
@ethouris ethouris added this to the v1.5.0 milestone Feb 7, 2020
@maxsharabayko maxsharabayko mentioned this pull request Feb 7, 2020
33 tasks
Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light edits to wording.

Creates an SRT socket:
Old and deprecated version of `srt_create_socket`. All arguments are ignored.

**NOTE** changes towards UDT version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE changes with respect to UDT version:

* `type`, `protocol`: ignored
* In UDT the `type` parameter was used to specify the file or message mode using
`SOCK_STREAM` or `SOCK_DGRAM` symbols (with the latter being misleading, as the
message mode has nothing to do with UDP datagrams and it's rather similar to SCTP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message mode has nothing to do with UDP datagrams and it's rather similar to the SCTP

Comment on lines 120 to 121
protocol). In SRT these two modes are available by setting `SRTO_TRANSTYPE` to
`SRTT_FILE`, and the message mode is set by `SRTO_MESSAGEAPI` option.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protocol). In SRT, set SRTO_TRANSTYPE to SRTT_FILE for file mode. Set the
SRTO_MESSAGEAPI option for message mode.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it a little bit, so please re-check. The situation is: SRTO_TRANSTYPE may be SRTT_LIVE (default) or SRTT_FILE (this is an option that changes various settings and sets some other options to different defaults - this needs no elaborate description here, just mentioning in short). The SRTO_MESSAGEAPI option is then set to default false, which means "stream" mode (TCP-like), and when set to true, it's "message" mode (SCTP-like).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:
--BEGIN (line 120)--
protocol). In SRT these two modes are available by setting SRTO_TRANSTYPE. The default
is SRTT_LIVE. If, however, you set SRTO_TRANSTYPE to SRTT_FILE for file mode, you
can then leave the SRTO_MESSAGEAPI option as false (default), which corresponds to
"stream" mode (TCP-like), or set it to true, which corresponds to "message" mode
(SCTP-like).
--END--

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.


Creates an SRT socket.

Note that socket IDs have always the `SRTGROUP_MASK` bit clear.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that socket IDs always have the SRTGROUP_MASK bit clear.

@@ -165,7 +166,9 @@ the communication. It is allowed that multiple SRT sockets share one local
outgoing port, as long as `SRTO_REUSEADDR` is set to *true* (default). Without
this call the port will be automatically selected by the system.

*See **NOTE** below under* [`srt_create_socket`](#srt_create_socket).
NOTE: This function cannot be called on socket group. If you have a need to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This function cannot be called on socket group. If you need to

docs/API.md Outdated
Comment on lines 999 to 1000
- Note that this flag set on a group is for group only, as it concerns the
exact receiving operation being done on a group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Note that this flag is for a group only, as it concerns a
    specific receiving operation being done on a group.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

docs/API.md Outdated
Comment on lines 1127 to 1128
- **[GET or SET]** - When true, sets blocking mode on writing function, when
it's not ready to perform the operation. When false ("non-blocking mode"), the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [GET or SET] - When true, sets blocking mode on a writing function when
    it's not ready to perform the operation. When false ("non-blocking mode"), the

docs/API.md Outdated
`SRT_EPOLL_OUT` flag.

- On a freshly created socket or group it will have no effect until the socket
turns into a connected state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enters a connected state.

docs/API.md Outdated
Comment on lines 1144 to 1145
- Note that this flag set on a group is for group only, as it concerns the
exact sending operation being done on a group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Note that this flag is for a group only, as it concerns a
    specific sending operation being done on a group.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same above.

docs/API.md Outdated
Comment on lines 1157 to 1158
- Note that this flag set on a group is for group only, as it concerns the
exact sending operation being done on a group.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Note that this flag is for a group only, as it concerns a
    specific sending operation being done on a group.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same above.

docs/API.md Outdated
- Note that this flag set on a group is for group only, as it concerns the
exact sending operation being done on a group.
- Note that when this flag is set only on a group, it applies to a
specific receiving operation being done on that group (i.e. it is not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific sending operation being done on that group (i.e. it is not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad blind copy pasting.

docs/API.md Outdated
- Note that this flag set on a group is for group only, as it concerns the
exact sending operation being done on a group.
- Note that when this flag is set only on a group, it applies to a
specific receiving operation being done on that group (i.e. it is not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific sending operation being done on that group (i.e. it is not

similar to the SCTP protocol). In SRT these two modes are available by setting
`SRTO_TRANSTYPE`. The default is `SRTT_LIVE`. If, however, you set
`SRTO_TRANSTYPE` to `SRTT_FILE` for file mode, you can then leave the
`SRTO_MESSAGEAPI option as false (default), which corresponds to "stream" mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRTO_MESSAGEAPI option as false (default), which corresponds to "stream" mode

Copy link
Collaborator

@stevomatthews stevomatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest edits are fine.

@maxsharabayko maxsharabayko merged commit 3dd5b75 into Haivision:master Feb 13, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[docs] Area: Improvements or additions to documentation Priority: High Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants