Added balancing group implementation. #1257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Priority: High
Type: Enhancement
| // least one packet behind, just wait for it to be ready. | ||
| // Use again the waiting function because we don't want | ||
| // the general waiting procedure to skip others. | ||
| set<SRTSOCKET> elephants; |
There was a problem hiding this comment.
dynamic memory allocation on every receive call
There was a problem hiding this comment.
These three concerns regarding this PR:
- The “window” algorithm needs a more descriptive name. Maybe "flightspan".
- Dynamic memory allocation on every receive call.
- Mixing two algorithms (fixed and window) in one PR.
Nothing dramatic though.
No. 1 and no. 2 can be addressed as technical debt.
No. 3 might make sense as a compromise to save time.
TODO
|
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted to draft because this is likely the abandoned prototype that uses synchronization on message numbers.