Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable reject reason code #1291

Merged
merged 4 commits into from
May 19, 2020
Merged

Customizable reject reason code #1291

merged 4 commits into from
May 19, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented May 15, 2020 •
edited by maxsharabayko
Loading

Fixes #1156

@ethouris ethouris requested a review from maxsharabayko May 15, 2020 10:47
@ethouris ethouris self-assigned this May 15, 2020
@ethouris ethouris added [core] Area: Changes in SRT library core Impact: Significant Priority: High Type: Enhancement Indicates new feature requests labels May 15, 2020
@ethouris ethouris added this to the v1.5.0 milestone May 15, 2020
maxsharabayko
maxsharabayko requested changes May 18, 2020
View reviewed changes
maxsharabayko
maxsharabayko reviewed May 18, 2020
View reviewed changes
maxsharabayko
maxsharabayko reviewed May 18, 2020
View reviewed changes
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think there should be two types of rejection reason codes: SRT internal and user defined. There should be no definition of SERVER and USER codes, as they are all user-defined codes.

@maxsharabayko maxsharabayko merged commit 9b6b124 into Haivision:master May 19, 2020
@maxsharabayko maxsharabayko mentioned this pull request May 22, 2020
Open
33 tasks
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees

@ethouris ethouris

Labels
[core] Area: Changes in SRT library core Priority: High Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

[FR] Enhance Rejection reason codes
3 participants
@ethouris @maxsharabayko @mbakholdina