-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appveyor vs2019 static ssl fix #1346
Appveyor vs2019 static ssl fix #1346
Conversation
-remove pthread nuget from build
-switch to C++11 mode
-clean out old appveyor RDP stuff -comment and sanitize build script
-add VSVER envvar back for artifact names -fix gather package to work with new _build folder
-PS set to erroraction stop
-find msbuild -add throw on nonzero msbuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the comments above and answer questions if possible.
This will probably hide this strange behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to improve AppVeyor build time.
Were previously disabled in Haivision#1346 to reduce build times.
Were previously disabled in #1346 to reduce build times.
This PR fixes a few things, and improves some others. In summary:
and finally... there it moves the actual build scripting work out of appveyor, into a dedicated (and much expanded) powershell script in the 'scripts' folder.
This new build script allows:
While this is a decent change to the build process, it does not invalidate the current windows building instructions - although they could potentially be reviewed after merging to see if there are further optimizations to those instructions. However, those instructions are very informative for people wishing to step away from the scripted build - so at most a 'quick start' section referring to this BAT-file based execution could be considered.
Finally, quite understandably, total time to run these builds is important - so even though more combinations have been added within this PR, through careful allocation of flags and skipping 2013 debug builds, the total build time is reduced by ~33% (~24 mins down from ~34mins)