Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle IPv4 connections on IPv6 listener #1355

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 18, 2020

Fixes #1318

  1. Fixed CIPAddress::pton to handle IPv4-on-IPv6.
  2. Made CreateAddr (new, replaces CreateAddrInet) handle IPv6.
  3. Made UriParser handle IPv6 spec.
  4. Fixes in sockaddr_any::len.

This PR also involves upgrades in the applications so that they can handle IPv6 correctly so that this can be tested. The upgrade doesn't reach all aspects, though, for example IPv6 multicast is not supported.

…handle IPv6. Made UriParser handle IPv6 spec. Fixes in sockaddr_any::len.
@ethouris ethouris self-assigned this Jun 18, 2020
@ethouris ethouris added [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Impact: High Priority: High Type: Bug Indicates an unexpected problem or unintended behavior labels Jun 18, 2020
@ethouris ethouris added this to the v1.5.0 milestone Jun 18, 2020
@ethouris ethouris marked this pull request as ready for review June 22, 2020 10:00
@maxsharabayko maxsharabayko modified the milestones: v1.5.0, v1.5.0 - Sprint 17 Jun 22, 2020
@maxsharabayko maxsharabayko merged commit d586c7f into Haivision:master Jun 22, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 17, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Priority: High Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] malformed sockaddr returned by srt_getsockname for IPv4mapped IPv6 address
3 participants