-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated features from SRT C API #1364
Merged
maxsharabayko
merged 8 commits into
Haivision:master
from
ethouris:dev-remove-deprecated-api
Jun 26, 2020
Merged
Removed deprecated features from SRT C API #1364
maxsharabayko
merged 8 commits into
Haivision:master
from
ethouris:dev-remove-deprecated-api
Jun 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
approved these changes
Jun 26, 2020
dvzrv
reviewed
Sep 26, 2020
@@ -11796,7 +11795,7 @@ static bool getOptDefault(SRT_SOCKOPT optname, void* pw_optval, int& w_optlen) | |||
|
|||
case SRTO_SENDER: RD(false); | |||
case SRTO_TSBPDMODE: RD(false); | |||
case SRTO_TSBPDDELAY: | |||
case SRTO_LATENCY: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming this breaks building vlc against srt 1.4.2.
A more specific commit message in regards to this change and why it was changed would have been nice and helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[apps]
Area: Test applications related improvements
[core]
Area: Changes in SRT library core
Priority: High
Type: Maintenance
Work required to maintain or clean up the code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994