Added proper error handling around sync resources #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
|
CodeFactor to ignore: Complex code in api.cpp. |
| { | ||
| gp = &newGroup(gtp); | ||
| } | ||
| catch (...) |
There was a problem hiding this comment.
Waiting for any certain exception or any?
There was a problem hiding this comment.
Probably only system exceptions and those freshly added here (although "added" is only in order to comply with the C++ std version).
| @@ -2827,7 +2843,7 @@ SRTSOCKET CUDT::createGroup(SRT_GROUP_TYPE gt) | |||
| { | |||
| return APIError(e); | |||
| } | |||
| catch (const std::bad_alloc& e) | |||
| catch (...) | |||
There was a problem hiding this comment.
Why bad_alock was not enough there?
There was a problem hiding this comment.
There could be some other types of exceptions thrown from the C++ standard library, as I remember. All of them qualify as IPE or at best lethal state of the system resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104
This adds error handling around sync resources. It's a shortcut for #1379 with only a fragment embracing the error handling.