[core] Fixed HS tbbpd flags check #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
maxsharabayko
force-pushed
the
hotfix/hs-len-check
branch
from
9589ba9
to
9a2da03
Compare
|
This pull request fixes 1 alert when merging 9a2da03 into d2f0e8a - view on LGTM.com fixed alerts:
|
ethouris
reviewed
Jul 30, 2020
|
@ethouris Updated the PR using |
|
This pull request fixes 1 alert when merging 23c72d7 into 152cff9 - view on LGTM.com fixed alerts:
|
ethouris
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison was always false because of
len >= 8due to the check above:if (len < SRT_CMD_HSREQ_MINSZ).So it should actually be (3 + 1) times
uint32.