Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Replaced CGuard with corresponding lock: UniqueLock or ScopedLock #1418

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

maxsharabayko
Copy link
Collaborator

Addresses an item in #1103.
CGuard was used as a temporal solution to avoid too many merge conflicts with the bonding functionality.
Now most of that functionality is merged, so it is relatively safe to replace CGuard with the corresponding lock: ScopedLock or UniqueLock.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Jul 27, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 - Sprint 20 milestone Jul 27, 2020
@maxsharabayko maxsharabayko requested a review from ethouris July 27, 2020 11:47
@maxsharabayko maxsharabayko mentioned this pull request Jul 27, 2020
18 tasks
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix in the comment descriptions. For the rest of the cases I state that UniqueLock was used exclusively in situation when there's needed the use of CV or enforced or scoped lifting of the mutex and ScopedLock everywhere else.

@maxsharabayko maxsharabayko merged commit 7ae4ba7 into Haivision:master Jul 29, 2020
@maxsharabayko maxsharabayko deleted the hotfix/remove-cguard branch July 29, 2020 07:25
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 20, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants