Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split-off POSIX sync version into a separate file #1455

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Aug 10, 2020

Recommended review:

  1. Compare existing files (filelist.maf and sync.cpp)
  2. Compare old sync.cpp against the new sync_posix.cpp: git difftool HEAD:sync.cpp sync_posix.cpp

Expected:

  1. Updated filelist.maf file to add conditionally sync_posix.cpp file
  2. Parts that are platform-dependent and implement POSIX version of sync are moved to sync_posix.cpp file.
  3. No other changes should be observed, especially changes in the moved parts.

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core Impact: Low labels Aug 10, 2020
@ethouris ethouris added this to the v1.5.0 - Sprint 20 milestone Aug 10, 2020
@ethouris ethouris self-assigned this Aug 10, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 20, v1.5.0 - Sprint 21 Aug 10, 2020
@ethouris
Copy link
Collaborator Author

Extra fix: Removed inline from the declaration of create_thread because it was causing a build break.

@maxsharabayko maxsharabayko merged commit 06d3c75 into Haivision:master Aug 11, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 21, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants