Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fallback for memory allocation errors #1459

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Fixed fallback for memory allocation errors #1459

merged 5 commits into from
Aug 13, 2020

Conversation

ethouris
Copy link
Collaborator

Fixes #1458

Changes:

  1. All new expressions dragged into under try clause.
  2. Pointers initialized to NULL to enable null-check
  3. All objects that succeeded to allocate, in case when fallen into a catch clause, are destroyed.

@ethouris ethouris self-assigned this Aug 11, 2020
@ethouris ethouris added the [core] Area: Changes in SRT library core label Aug 11, 2020
@ethouris ethouris added this to the v1.5.0 - Sprint 21 milestone Aug 11, 2020
@ethouris ethouris added Impact: Low Priority: High Type: Maintenance Work required to maintain or clean up the code labels Aug 11, 2020
@ethouris
Copy link
Collaborator Author

CodeFactor: ignore complex code.

maxsharabayko
maxsharabayko reviewed Aug 11, 2020
View reviewed changes
srtcore/api.cpp Outdated Show resolved Hide resolved
@ethouris @maxsharabayko
Remove extra condition before delete.
2213138 
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
maxsharabayko
maxsharabayko reviewed Aug 11, 2020
View reviewed changes
srtcore/api.cpp Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko merged commit 7e4554f into Haivision:master Aug 13, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 21, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees

@ethouris ethouris

Labels
[core] Area: Changes in SRT library core Priority: High Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak if exception is thrown
3 participants
@ethouris @maxsharabayko @mbakholdina