Fixed bug: write back actual sending time if no source time supplied #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Priority: Critical
Type: Bug
|
buffer.h /// OUTPUT:
/// - srctime: local time that was used to stamp the packetChange to something like: |
maxsharabayko
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: the actual sending time is available back after calling
sendmsg2. If no source time supplied, this field will be written with the value of "origin time" (time when the packet was scheduled for sending). This way the next call in the group sender will pick up the time rewritten by the previous call and supply identical time for the same packet sent over a different link.Formula fixed for
getSourceTime: them_tsOriginTimewas actually reduced in this equation making false impression that this value participates in the equation.