-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some problems in group code found during review #1505
Merged
maxsharabayko
merged 8 commits into
Haivision:master
from
ethouris:dev-fix-review-errors
Sep 2, 2020
Merged
Fixed some problems in group code found during review #1505
maxsharabayko
merged 8 commits into
Haivision:master
from
ethouris:dev-fix-review-errors
Sep 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Type: Maintenance
Work required to maintain or clean up the code
[core]
Area: Changes in SRT library core
Impact: High
labels
Aug 28, 2020
Comment on lines
+1865
to
+1870
// NOTE: this code remains as is for historical reasons. | ||
// The initial implementation stated that the peer id be | ||
// extracted so that it can be reported and possibly the | ||
// start time somehow encoded and written into the group | ||
// extension, but it was later seen not necessary. Therefore | ||
// this code remains, but now it's informational only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it valid now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This explains why this call is here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[core]
Area: Changes in SRT library core
Type: Maintenance
Work required to maintain or clean up the code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things found during the review:
The use of
getMasterData
has proven to be now informative only - therefore the whole call is put under ENABLE_HEAVY_LOGGING condition for clarity.Comparison of the expected peer id in case when the group is not empty should result in rejection. This is a probable situation if the user has mistakenly made two connections within a group, but these endpoints do not designate the same application at the peer side. In this case the returned peer group ID will be different for the second member socket, and this means that the address of the second connection is wrong, stating that the first was right.