Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reports from LGTM #1542

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Fixed reports from LGTM #1542

merged 3 commits into from
Oct 20, 2020

Conversation

ethouris
Copy link
Collaborator

Fixes #1447

This PR currently prepares the solution, but it must be also tested:

  1. Single socket transmission with restarting transmission (use srt-live-transmit for testing)
  2. For Backup groups, with transmission stopped and restarted over a running connection. One link suffices.
  3. srt-tunnel with connection established and broken several times

@ethouris ethouris self-assigned this Sep 11, 2020
@ethouris ethouris added [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Impact: High Type: Maintenance Work required to maintain or clean up the code labels Sep 11, 2020
@ethouris ethouris added this to the v1.5.0 - Sprint 23 milestone Sep 11, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 11, 2020

This pull request introduces 1 alert and fixes 5 when merging 9465a39 into e756477 - view on LGTM.com

new alerts:

  • 1 for Virtual call from constructor or destructor

fixed alerts:

  • 4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Multiplication result converted to larger type

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 14, 2020

This pull request fixes 6 alerts when merging 2ec2e41 into e756477 - view on LGTM.com

fixed alerts:

  • 4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Resource not released in destructor
  • 1 for Multiplication result converted to larger type

@ethouris ethouris marked this pull request as ready for review September 14, 2020 14:22
@maxsharabayko maxsharabayko self-assigned this Sep 14, 2020
@maxsharabayko maxsharabayko modified the milestones: v1.5.0 - Sprint 23, v1.5.0 - Sprint 25 Sep 21, 2020
@maxsharabayko maxsharabayko modified the milestones: v1.5.0 - Sprint 25, v1.5.0 - Sprint 26 Oct 12, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 26, v1.5.0 Oct 14, 2020
@maxsharabayko maxsharabayko merged commit e145ca5 into Haivision:master Oct 20, 2020
@maxsharabayko
Copy link
Collaborator

The following static check error was introduced by this PR.
Link to sonarcloud.

8 uninitialized fields at the end of the constructor call
CInfoBlock ib; // core.cpp#L4957

@maxsharabayko maxsharabayko modified the milestones: v1.5.0, v1.4.3 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko Awaiting requested review from maxsharabayko

Assignees

@ethouris ethouris

@maxsharabayko maxsharabayko

Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

Fix LGTM static check issues:
3 participants
@ethouris @maxsharabayko @mbakholdina