Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Not adding socket to group when address buffer is not set #1544

Merged
merged 1 commit into from
Sep 15, 2020
Merged

[BUG] Not adding socket to group when address buffer is not set #1544

merged 1 commit into from
Sep 15, 2020

Conversation

Llorx
Copy link
Contributor

@Llorx Llorx commented Sep 13, 2020

This will still add the socket to the group when you don't need to set address buffer.

@maxsharabayko maxsharabayko added this to the v1.5.0 - Sprint 23 milestone Sep 14, 2020
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Sep 14, 2020
ethouris
ethouris approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thanks for finding it.

@maxsharabayko maxsharabayko merged commit c576662 into Haivision:master Sep 15, 2020
@Llorx Llorx deleted the patch-1 branch September 15, 2020 09:59
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 23, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees

@ethouris ethouris

Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Llorx @ethouris @maxsharabayko @mbakholdina