[core] Removed SRTO_ESTINPUTBW #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
maxsharabayko
force-pushed
the
develop/remove-estinputbw
branch
from
87d5675
to
1efce6a
Compare
ethouris
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket option was introduced in PR #1537 recently to allow getting the estimated input bitrate value.
However, it should not be a socket option, but more a statistics entry.
Furthermore, there is already the mbpsMaxBW statistic that depicts the estimated input bitrate value (when the corresponding mode is used
SRTO_INPUTBW=0andSRTO_MAXBW=0) as estimated value multiplied by (100% +SRT_OHEADBW).Therefore removing the option.