Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Mark bonding experimental #1563

Merged
merged 8 commits into from
Sep 22, 2020
Merged

[MAINT] Mark bonding experimental #1563

merged 8 commits into from
Sep 22, 2020

Conversation

ethouris
Copy link
Collaborator

No description provided.

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core [build] Area: Changes in build files [third-party] Area: Issues with SRT in third-party projects [API] Area: Changes in SRT library API labels Sep 21, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 21, 2020

This pull request fixes 1 alert when merging 4233067 into 122df96 - view on LGTM.com

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

maxsharabayko
maxsharabayko reviewed Sep 21, 2020
View reviewed changes
@maxsharabayko maxsharabayko added this to the v1.5.0 - Sprint 24 milestone Sep 21, 2020
@ethouris ethouris marked this pull request as ready for review September 21, 2020 16:05
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 21, 2020

This pull request fixes 1 alert when merging 186b838 into 122df96 - view on LGTM.com

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

@mbakholdina mbakholdina added Priority: High and removed [API] Area: Changes in SRT library API [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core [third-party] Area: Issues with SRT in third-party projects labels Sep 21, 2020
@maxsharabayko
Copy link
Collaborator

Build failures in AppVeyor

(ClCompile target) -> 
  C:\projects\srt\srtcore\core.cpp(8815,1): error C2121: '#': invalid character: possibly the result of a macro expansion [C:\projects\srt\_build\srt_virtual.vcxproj]
  C:\projects\srt\srtcore\core.cpp(8809,1): error C2143: syntax error: missing ';' before 'if' [C:\projects\srt\_build\srt_virtual.vcxproj]
  C:\projects\srt\srtcore\core.cpp(8815,1): error C2061: syntax error: identifier 'ENABLE_EXPERIMENTAL_BONDING' [C:\projects\srt\_build\srt_virtual.vcxproj]

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 22, 2020

This pull request fixes 1 alert when merging 9858238 into 122df96 - view on LGTM.com

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

@maxsharabayko maxsharabayko merged commit 39916e0 into Haivision:master Sep 22, 2020
@mbakholdina mbakholdina modified the milestones: v1.5.0 - Sprint 24, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsharabayko maxsharabayko maxsharabayko approved these changes

Assignees

@ethouris ethouris

@maxsharabayko maxsharabayko

Labels
[build] Area: Changes in build files Priority: High Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ethouris @maxsharabayko @mbakholdina